fix: inherit flags of input functions#3483
Conversation
📝 WalkthroughWalkthroughThis pull request refines the processing of wildcards by modifying the handling of callable items in the Snakemake rules. In the Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant Rule
participant Concretize
Caller->>Rule: call _apply_wildcards(newitems, olditems, wildcards)
Note right of Rule: Check if item is callable
alt Item is callable
Rule->>Rule: Assign olditem to from_callable
else Item is not callable
Rule->>Rule: Set from_callable to None
end
Rule->>Rule: Check if from_callable is not None
Rule->>Concretize: Call concretize(from_callable)
Concretize-->>Rule: Return processed result
Rule-->>Caller: Return updated wildcards
sequenceDiagram
participant RuleE
participant Snakefile
participant GetE
RuleE->>Snakefile: Request input for rule e
Snakefile->>GetE: call get_e_input(wildcards)
GetE-->>Snakefile: return input filename
Snakefile-->>RuleE: Provide dynamic input filename
sequenceDiagram
participant RuleF
participant Snakefile
participant GetF
RuleF->>Snakefile: Request input for rule f
Snakefile->>GetF: call get_f_input(wildcards)
GetF-->>Snakefile: return input filename
Snakefile-->>RuleF: Provide dynamic input filename
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🧰 Additional context used📓 Path-based instructions (1)`**/*.py`: Do not try to improve formatting. Do not suggest type annotations for functions that are defined inside of functions or methods. Do not suggest type annotation of the `s...
⏰ Context from checks skipped due to timeout of 90000ms (35)
🔇 Additional comments (8)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
🤖 I have created a release *beep* *boop* --- ## [9.1.2](v9.1.1...v9.1.2) (2025-03-26) ### Bug Fixes * inherit flags of input functions ([#3483](#3483)) ([6bd981e](6bd981e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
### QC <!-- Make sure that you can tick the boxes below. --> * [x] The PR contains a test case for the changes or the changes are already covered by an existing test case. * [x] The documentation (`docs/`) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake). <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced dynamic input filename generation based on dataset parameters, offering more flexible and intuitive file specification in workflows. - **Refactor** - Enhanced the underlying input processing logic to improve consistency and reliability when handling user-defined file patterns. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
🤖 I have created a release *beep* *boop* --- ## [9.1.2](snakemake/snakemake@v9.1.1...v9.1.2) (2025-03-26) ### Bug Fixes * inherit flags of input functions ([snakemake#3483](snakemake#3483)) ([6bd981e](snakemake@6bd981e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
QC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).Summary by CodeRabbit
New Features
Refactor