Skip to content

fix: ensure user and group rw permissions for metadata files and source cache#2132

Merged
johanneskoester merged 6 commits intomainfrom
fix/persistence-permissions
Feb 28, 2023
Merged

fix: ensure user and group rw permissions for metadata files and source cache#2132
johanneskoester merged 6 commits intomainfrom
fix/persistence-permissions

Conversation

@johanneskoester
Copy link
Copy Markdown
Contributor

This way, multiple users can more conveniently work on the same workdir.

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

Copy link
Copy Markdown
Member

@dlaehnemann dlaehnemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Although I don't have a clue if this is all the places where this might need fixing... 😬

@github-actions
Copy link
Copy Markdown
Contributor

Please format your code with black: black snakemake tests/*.py.

@johanneskoester johanneskoester merged commit cc51faa into main Feb 28, 2023
@johanneskoester johanneskoester deleted the fix/persistence-permissions branch February 28, 2023 19:07
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

johanneskoester pushed a commit that referenced this pull request Mar 1, 2023
🤖 I have created a release *beep* *boop*
---


##
[7.24.0](v7.23.1...v7.24.0)
(2023-03-01)


### Features

* limit the number of input/output files in job properties
([#2149](#2149))
([d93f091](d93f091))


### Bug Fixes

* [#2130](#2130) by
patching the protect() method so the path of files in subdirectories is
properly resolved during write-protection
([#2131](#2131))
([1a754fd](1a754fd))
* `sre_constants` import because of deprecation
([#2139](#2139))
([3b326db](3b326db))
* ensure user and group rw permissions for metadata files and source
cache ([#2132](#2132))
([cc51faa](cc51faa))
* is_run error with local, group jobs
([#2133](#2133))
([31bfcd5](31bfcd5))
* require toposort >= 1.10
([#2145](#2145))
([3cb54b8](3cb54b8))


### Documentation

* Update modularization.rst
([#2137](#2137))
([16954c7](16954c7))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants