fix: use host in port check (#222)

Brian Burns · gregberge · commit e419eb2757e8 · 2019-07-14T23:22:52.000+02:00
diff --git a/packages/jest-dev-server/src/global.js b/packages/jest-dev-server/src/global.js
@@ -89,7 +89,7 @@ async function outOfStin(block) {
   return result
 }
 
-function getIsPortTaken(port) {
+function getIsPortTaken(config) {
   let server
   const cleanupAndReturn = result =>
     new Promise(resolve => server.once('close', () => resolve(result)).close())
@@ -100,7 +100,7 @@ function getIsPortTaken(port) {
         err.code === 'EADDRINUSE' ? resolve(cleanupAndReturn(true)) : reject(),
       )
       .once('listening', () => resolve(cleanupAndReturn(false)))
-      .listen(port)
+      .listen(config.port, config.host)
   })
 }
 
@@ -135,7 +135,7 @@ async function setupJestServer(providedConfig, index) {
       )
       const [portProcess] = await findProcess('port', config.port)
       logProcDetection(portProcess, config.port)
-      killProc(portProcess)
+      await killProc(portProcess)
     },
     async ask() {
       console.log('')
@@ -171,7 +171,7 @@ async function setupJestServer(providedConfig, index) {
   }
 
   if (config.port) {
-    const isPortTaken = await getIsPortTaken(config.port)
+    const isPortTaken = await getIsPortTaken(config)
     if (isPortTaken) {
       await usedPortHandler()
     }

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ async function outOfStin(block) {`
`89`	`89`	`return result`
`90`	`90`	`}`
`91`	`91`
`92`		`-function getIsPortTaken(port) {`
	`92`	`+function getIsPortTaken(config) {`
`93`	`93`	`let server`
`94`	`94`	`const cleanupAndReturn = result =>`
`95`	`95`	`new Promise(resolve => server.once('close', () => resolve(result)).close())`
`@@ -100,7 +100,7 @@ function getIsPortTaken(port) {`
`100`	`100`	`err.code === 'EADDRINUSE' ? resolve(cleanupAndReturn(true)) : reject(),`
`101`	`101`	`)`
`102`	`102`	`.once('listening', () => resolve(cleanupAndReturn(false)))`
`103`		`- .listen(port)`
	`103`	`+ .listen(config.port, config.host)`
`104`	`104`	`})`
`105`	`105`	`}`
`106`	`106`
`@@ -135,7 +135,7 @@ async function setupJestServer(providedConfig, index) {`
`135`	`135`	`)`
`136`	`136`	`const [portProcess] = await findProcess('port', config.port)`
`137`	`137`	`logProcDetection(portProcess, config.port)`
`138`		`- killProc(portProcess)`
	`138`	`+ await killProc(portProcess)`
`139`	`139`	`},`
`140`	`140`	`async ask() {`
`141`	`141`	`console.log('')`
`@@ -171,7 +171,7 @@ async function setupJestServer(providedConfig, index) {`
`171`	`171`	`}`
`172`	`172`
`173`	`173`	`if (config.port) {`
`174`		`- const isPortTaken = await getIsPortTaken(config.port)`
	`174`	`+ const isPortTaken = await getIsPortTaken(config)`
`175`	`175`	`if (isPortTaken) {`
`176`	`176`	`await usedPortHandler()`
`177`	`177`	`}`