Skip to content

minimum supported async-task version is 4.4.0#90

Merged
notgull merged 1 commit intosmol-rs:masterfrom
jbr:fix-async-task-minimum-dependency
Feb 13, 2024
Merged

minimum supported async-task version is 4.4.0#90
notgull merged 1 commit intosmol-rs:masterfrom
jbr:fix-async-task-minimum-dependency

Conversation

@jbr
Copy link
Copy Markdown
Contributor

@jbr jbr commented Feb 13, 2024

This crate depends on async_task::Builder, which was introduced in 4.4.0

Detected with cargo-minimal-versions

this crate depends on async_task::Builder, which was introduced in 4.4.0
Copy link
Copy Markdown
Contributor

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@notgull notgull merged commit 0baba46 into smol-rs:master Feb 13, 2024
@notgull
Copy link
Copy Markdown
Contributor

notgull commented Feb 13, 2024

@taiki-e Do you think it would be worth checking cargo-minimal-versions in CI?

@notgull notgull mentioned this pull request Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants