Merged
Conversation
Closes smol-rs#135. This enables the executor to be used in presence of panics in user callbacks, such as the iterator and `impl Extend` in `spawn_many`. Mutex poisoning is more of a lint than a safety requirement, as containers (such as `Slab`) and wakers have to be sound in presence of panics anyway. In this particular case, the exact behavior of `active` is not relied upon for soundness.
Merged
notgull
approved these changes
Dec 3, 2024
Contributor
notgull
left a comment
There was a problem hiding this comment.
Looks good to me. I guess my main question would be "what happens to the tasks that are already spawned", but I think this is answered now.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #135.
This enables the executor to be used in presence of panics in user callbacks, such as the iterator and
impl Extendinspawn_many.Mutex poisoning is more of a lint than a safety requirement, as containers (such as
Slab) and wakers have to be sound in presence of panics anyway. In this particular case, the exact behavior ofactiveis not relied upon for soundness.