feat: reexport async_task::FallibleTask#113
Merged
notgull merged 1 commit intosmol-rs:masterfrom Apr 11, 2024
jbr:reexport-fallible-task
Merged
feat: reexport async_task::FallibleTask#113notgull merged 1 commit intosmol-rs:masterfrom jbr:reexport-fallible-task
notgull merged 1 commit intosmol-rs:masterfrom
jbr:reexport-fallible-task
Conversation
notgull
approved these changes
Apr 11, 2024
Contributor
notgull
left a comment
There was a problem hiding this comment.
Thanks!
I'm a little tempted to not provide it, since the task scheduler in this case is infallible. However I guess it's part of the public API whether we like it or not.
Contributor
Author
|
Is that true even in case of task panic? |
Contributor
|
When the task panics the panic is caught and later propagated to the task that is polling the |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: FallibleTask is part of the public interface of this crate, in that Task::fallible returns FallibleTask. However, in order to name that type, users need to add a direct dependency on async_task and ensure the crates versions are compatible. Reexporting allows crate users to name the type directly.
Thanks!