Merged
Conversation
0d11fc3 to
305f8b9
Compare
yefrig
reviewed
Aug 21, 2025
| define sources and dependencies, they will be merged together and de-duplicated. | ||
|
|
||
| ## Features | ||
|
|
Contributor
There was a problem hiding this comment.
Maybe not needed for now but it might be nice to add image/gifs for these features. Something like: https://github.com/fwcd/kotlin-language-server?tab=readme-ov-file#features
| /// List of file or directory paths containing the source Smithy files in | ||
| /// the project. | ||
| sources: Strings | ||
|
|
Contributor
There was a problem hiding this comment.
We should document all of them to be consistent
Contributor
Author
There was a problem hiding this comment.
I left some undocumented here and in the readme because they're extraneous. Added comments in the model
Added installation instructions, feature list, and details on how the server understands your project (including documenting .smithy-project.json). I also added doc comments to the `SmithyProjectJson` shape.
yefrig
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added installation instructions, feature list, and details on how the server understands your project (including documenting .smithy-project.json). I also added doc comments to the
SmithyProjectJsonshape.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.