Skip to content

Add stubs for setTrace and cancelProgress#183

Merged
milesziemer merged 1 commit intosmithy-lang:mainfrom
milesziemer:add-settrace-stub
Dec 18, 2024
Merged

Add stubs for setTrace and cancelProgress#183
milesziemer merged 1 commit intosmithy-lang:mainfrom
milesziemer:add-settrace-stub

Conversation

@milesziemer
Copy link
Copy Markdown
Contributor

Lsp4j provides default implementations of these methods in the LanguageServer interface, which throw exceptions. Even though we don't support this server side, better to give a warning than shutdown the server.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Lsp4j provides default implementations of these methods in the
LanguageServer interface, which throw exceptions. Even though we don't
support this server side, better to give a warning than shutdown the
server.
@milesziemer milesziemer requested a review from a team as a code owner December 18, 2024 20:14
@milesziemer milesziemer requested a review from sugmanue December 18, 2024 20:14
@milesziemer milesziemer requested review from yefrig and removed request for sugmanue December 18, 2024 20:14
@milesziemer milesziemer merged commit 5c9c72d into smithy-lang:main Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants