check internet connection before hitting endpoint#28
Merged
jokodee merged 3 commits intosmbcloudXYZ:developmentfrom Jul 3, 2025
Merged
check internet connection before hitting endpoint#28jokodee merged 3 commits intosmbcloudXYZ:developmentfrom
jokodee merged 3 commits intosmbcloudXYZ:developmentfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds an active internet connectivity check before issuing HTTP requests, surface a new network error when offline, and enforces connectivity at the CLI level.
- Introduces
check_internet_connectionand integrates it intorequest() - Updates
ErrorCode::NetworkErrormessage to reference connectivity - Guards CLI commands with a pre-flight connectivity check
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| crates/smbcloud-networking/src/network.rs | Adds check_internet_connection and plugs it into request() |
| crates/smbcloud-networking/src/lib.rs | Re-exports the connectivity check function |
| crates/smbcloud-model/src/error_codes.rs | Refines NetworkError attribute and default message |
| crates/cli/src/main.rs | Applies connectivity check before running commands |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
paydii
approved these changes
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.