I think this will fix it, by replacing the last "else" block in plugins/shared.mb_str_replace.php with this:

        } else {
            $want_encoding = 'UTF-8';
            $must_transcode = function_exists('mb_convert_encoding') && strcasecmp(Smarty::$_CHARSET, $want_encoding);
            if ($must_transcode) {
                $search  = mb_convert_encoding($search , $want_encoding, Smarty::$_CHARSET);
                $replace = mb_convert_encoding($replace, $want_encoding, Smarty::$_CHARSET);
                $subject = mb_convert_encoding($subject, $want_encoding, Smarty::$_CHARSET);
            }
            $parts = preg_split('/' . preg_quote($search, '/') . '/u', $subject);
            $count = count($parts) - 1;
            $subject = implode($replace, $parts);
            if ($must_transcode) {
                $subject = mb_convert_encoding($subject, Smarty::$_CHARSET, $want_encoding);
            }
        }

It needs testing though.
Edit: Slightly optimized update using preg_replace instead of preg_split + count + implode:

        } else {
            $want_encoding = 'UTF-8';
            $must_transcode = function_exists('mb_convert_encoding') && strcasecmp(Smarty::$_CHARSET, $want_encoding);
            if ($must_transcode) {
                $search  = mb_convert_encoding($search , $want_encoding, Smarty::$_CHARSET);
                $replace = mb_convert_encoding($replace, $want_encoding, Smarty::$_CHARSET);
                $subject = mb_convert_encoding($subject, $want_encoding, Smarty::$_CHARSET);
            }
            $subject = preg_replace('/' . preg_quote($search, '/') . '/u', $replace, $subject, -1, $count);
            if ($must_transcode) {
                $subject = mb_convert_encoding($subject, Smarty::$_CHARSET, $want_encoding);
            }
        }

The function should do better argument type checking b.t.w. to handle objects, nulls, etc. being passed in.

Uh oh!

problems with smarty_mb_str_replace PHP >= 7.1 #549

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions