Skip to content

Added support for extracting strings of a specific domain only#19

Merged
glensc merged 6 commits intosmarty-gettext:masterfrom
myfonts:master
May 12, 2017
Merged

Added support for extracting strings of a specific domain only#19
glensc merged 6 commits intosmarty-gettext:masterfrom
myfonts:master

Conversation

@muse-monotype
Copy link
Copy Markdown
Contributor

  • Use -d to extract gettext strings of default (empty) domain only
  • Use -d=custom to extract gettext strings of "custom" domain only (e.g. all strings defined with {t domain="custom"}...)

@glensc
Copy link
Copy Markdown
Member

glensc commented May 12, 2017

the changes look clean, i'll squash merge this

altho i consider this tool obsolete, when new tool is ready:
smarty-gettext/tsmarty2c#1

@glensc glensc merged commit ff592d2 into smarty-gettext:master May 12, 2017
@muse-monotype
Copy link
Copy Markdown
Contributor Author

Thanks! Do you plan a new official release that includes the changes? Would be much appreciated.

Looking forward to the initial release of the rewritten tool.
In regards to domain support, it would be nice to add an option to automatically output strings into separate files per domain (.pot) during parsing. With the current code, this would have required major refactoring. So we went with the simple filtering approach for now. Maybe you can plan for this in the new tool architecture.

@glensc
Copy link
Copy Markdown
Member

glensc commented May 12, 2017

file as ticket in the new project what's the goal how you see the interface. or wait when current functionality is there and submit PR.

and yes. i'll do release soonish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants