-
Notifications
You must be signed in to change notification settings - Fork 14
Add support for syncing ACME accounts #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit adds support for syncing ACME accounts with majordomo.
7795a6e to
65dfe01
Compare
| message CreateACMEAccountRequest { | ||
| string preferred_id = 1; | ||
| bytes jwk = 2; | ||
| ACMEAccount.Status status = 3; | ||
| repeated string contact = 4; | ||
| bool terms_of_service_agreed = 5; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be a property to link this to a specific provisioner? I remember we used to allow an ACME account to be used with any ACME provisioner in the past, but I believe we changed that at some point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not in this case, the intention is to sync accounts between different authorities, and those will have different provisioners.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the goal is to have linked authority X sync ACME accounts from provisioner Y to majordomo, so that linked authority Z get the accounts too, and for those to be active for all provisioners? And those authorities are totally independent; not clustered?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, they can be two different environments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with this if it is a functional requirement, but it could result in surprising results to the end users.
This commit adds support for syncing ACME accounts with majordomo.