Skip to content

[Bug]: Flaky softkms test #972

@hslatman

Description

@hslatman

Steps to Reproduce

Just nothing this here for now. It went away after a retry. There seems to be a null byte at the beginning of the key. Possibly some encoding/decoding issue when serializing the key?

See: https://github.com/smallstep/crypto/actions/runs/22954661938/job/66628040231

kms_test.go:500: 
        	Error Trace:	/home/runner/work/crypto/crypto/kms/platform/kms_test.go:500
        	            				/home/runner/work/crypto/crypto/kms/platform/kms_test.go:568
        	Error:      	Not equal: 
        	            	expected: &apiv1.CreateKeyResponse{Name:"kms:name=%2Ftmp%2FTestKMS_CreateKey2794690563%2F001%2Fprivate.key", PublicKey:(*rsa.PublicKey)(0x17a64d8e5880), PrivateKey:(*rsa.PrivateKey)(0x17a64d8e5880), CreateSignerRequest:apiv1.CreateSignerRequest{Signer:(*rsa.PrivateKey)(0x17a64d8e5880), SigningKey:"kms:name=%2Ftmp%2FTestKMS_CreateKey2794690563%2F001%2Fprivate.key", SigningKeyPEM:[]uint8(nil), TokenLabel:"", PublicKey:"", PublicKeyPEM:[]uint8(nil), Password:[]uint8(nil), PasswordPrompter:(apiv1.PasswordPrompter)(nil)}}
        	            	actual  : &apiv1.CreateKeyResponse{Name:"kms:name=%2Ftmp%2FTestKMS_CreateKey2794690563%2F001%2Fprivate.key", PublicKey:(*rsa.PublicKey)(0x17a64d8e59d0), PrivateKey:(*rsa.PrivateKey)(0x17a64d8e59d0), CreateSignerRequest:apiv1.CreateSignerRequest{Signer:(*rsa.PrivateKey)(0x17a64d8e59d0), SigningKey:"kms:name=%2Ftmp%2FTestKMS_CreateKey2794690563%2F001%2Fprivate.key", SigningKeyPEM:[]uint8(nil), TokenLabel:"", PublicKey:"", PublicKeyPEM:[]uint8(nil), Password:[]uint8(nil), PasswordPrompter:(apiv1.PasswordPrompter)(nil)}}
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -616,15 +616,15 @@
        	            	     },
        	            	-    dQ: ([]uint8) (len=192) {
        	            	-     00000000  00 4e 42 75 66 61 0a bf  01 f5 0f b7 ba 83 a5 bd  |.NBufa..........|
        	            	-     00000010  55 27 ff 8f 9b 6f 9f 09  9e 93 11 82 d0 7b d2 ef  |U'...o.......{..|
        	            	-     00000020  62 3b 5d 21 b0 b5 62 dc  36 cf 76 1b e4 74 59 5f  |b;]!..b.6.v..tY_|
        	            	-     00000030  39 71 0c 17 6d 58 95 20  c2 1b e4 db 8c ac 27 55  |9q..mX. ......'U|
        	            	-     00000040  6b 30 1a a3 7a 1b 4a 1b  a7 f3 61 ab f0 23 df a8  |k0..z.J...a..#..|
        	            	-     00000050  84 43 46 04 db ee 0c 30  6b 83 a2 48 44 8b 2e 51  |.CF....0k..HD..Q|
        	            	-     00000060  90 a8 40 c9 ef 78 73 17  92 7f 49 02 3c fa 01 15  |..@..xs...I.<...|
        	            	-     00000070  aa 53 30 96 33 b3 30 41  15 06 c2 c0 48 22 ef 4d  |.S0.3.0A....H".M|
        	            	-     00000080  e5 7b 2c d2 6e 13 3f bd  ad fa d8 bf 8d f9 cc 82  |.{,.n.?.........|
        	            	-     00000090  02 46 f1 f2 7b 87 2b 18  86 79 12 14 13 e2 a8 f1  |.F..{.+..y......|
        	            	-     000000a0  dd 5b 37 01 72 52 4d 80  3e a3 d0 19 b4 a0 f8 58  |.[7.rRM.>......X|
        	            	-     000000b0  f6 53 fa 2a 93 88 c2 2a  66 f5 51 56 ca bf 58 ed  |.S.*...*f.QV..X.|
        	            	+    dQ: ([]uint8) (len=191) {
        	            	+     00000000  4e 42 75 66 61 0a bf 01  f5 0f b7 ba 83 a5 bd 55  |NBufa..........U|
        	            	+     00000010  27 ff 8f 9b 6f 9f 09 9e  93 11 82 d0 7b d2 ef 62  |'...o.......{..b|
        	            	+     00000020  3b 5d 21 b0 b5 62 dc 36  cf 76 1b e4 74 59 5f 39  |;]!..b.6.v..tY_9|
        	            	+     00000030  71 0c 17 6d 58 95 20 c2  1b e4 db 8c ac 27 55 6b  |q..mX. ......'Uk|
        	            	+     00000040  30 1a a3 7a 1b 4a 1b a7  f3 61 ab f0 23 df a8 84  |0..z.J...a..#...|
        	            	+     00000050  43 46 04 db ee 0c 30 6b  83 a2 48 44 8b 2e 51 90  |CF....0k..HD..Q.|
        	            	+     00000060  a8 40 c9 ef 78 73 17 92  7f 49 02 3c fa 01 15 aa  |.@..xs...I.<....|
        	            	+     00000070  53 30 96 33 b3 30 41 15  06 c2 c0 48 22 ef 4d e5  |S0.3.0A....H".M.|
        	            	+     00000080  7b 2c d2 6e 13 3f bd ad  fa d8 bf 8d f9 cc 82 02  |{,.n.?..........|
        	            	+     00000090  46 f1 f2 7b 87 2b 18 86  79 12 14 13 e2 a8 f1 dd  |F..{.+..y.......|
        	            	+     000000a0  5b 37 01 72 52 4d 80 3e  a3 d0 19 b4 a0 f8 58 f6  |[7.rRM.>......X.|
        	            	+     000000b0  53 fa 2a 93 88 c2 2a 66  f5 51 56 ca bf 58 ed     |S.*...*f.QV..X.|
        	            	     },
        	Test:       	TestKMS_CreateKey/ok_softKMS_escape

Your Environment

  • OS -
  • Version -

Expected Behavior

Non-flaky test

Actual Behavior

Flaky test

Additional Context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions