Apply suggestions from code review

maraino · hslatman · maraino · commit 69660dc06f18 · 2024-03-19T10:38:07.000-07:00
Co-authored-by: Herman Slatman &lt;hslatman@users.noreply.github.com&gt;
diff --git a/kms/mackms/mackms.go b/kms/mackms/mackms.go
@@ -356,7 +356,7 @@ func (k *MacKMS) LoadCertificate(req *apiv1.LoadCertificateRequest) (*x509.Certi
 //
 // Valid names (URIs) are:
 //   - "" will use the common name as the label
-//   - "mackms:" will use the common
+//   - "mackms:" will use the common name
 //   - "mackms:label=my-label" will use "my-label"
 //   - "mackms:my-label" will use the "my-label"
 func (k *MacKMS) StoreCertificate(req *apiv1.StoreCertificateRequest) error {
@@ -706,7 +706,6 @@ func isSelfSigned(cert *x509.Certificate) bool {
 	}
 
 	return false
-
 }
 
 func loadCertificate(label string, serialNumber *big.Int, subjectKeyID []byte) (*x509.Certificate, error) {

Original file line number	Diff line number	Diff line change
`@@ -356,7 +356,7 @@ func (k MacKMS) LoadCertificate(req apiv1.LoadCertificateRequest) (*x509.Certi`
`356`	`356`	`//`
`357`	`357`	`// Valid names (URIs) are:`
`358`	`358`	`// - "" will use the common name as the label`
`359`		`-// - "mackms:" will use the common`
	`359`	`+// - "mackms:" will use the common name`
`360`	`360`	`// - "mackms:label=my-label" will use "my-label"`
`361`	`361`	`// - "mackms:my-label" will use the "my-label"`
`362`	`362`	`func (k MacKMS) StoreCertificate(req apiv1.StoreCertificateRequest) error {`
`@@ -706,7 +706,6 @@ func isSelfSigned(cert *x509.Certificate) bool {`
`706`	`706`	`}`
`707`	`707`
`708`	`708`	`return false`
`709`		`-`
`710`	`709`	`}`
`711`	`710`
`712`	`711`	`func loadCertificate(label string, serialNumber big.Int, subjectKeyID []byte) (x509.Certificate, error) {`