Skip to content

Conversation

@hslatman
Copy link
Member

@hslatman hslatman commented May 21, 2025

Replaces #2273, #2274 and #2275.

Fixes new linter issues.

dependabot bot and others added 2 commits May 19, 2025 15:44
Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.232.0 to 0.233.0.
- [Release notes](https://github.com/googleapis/google-api-go-client/releases)
- [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md)
- [Commits](googleapis/google-api-go-client@v0.232.0...v0.233.0)

---
updated-dependencies:
- dependency-name: google.golang.org/api
  dependency-version: 0.233.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label May 21, 2025
@hslatman hslatman added this to the v0.28.4 milestone May 21, 2025
@hslatman hslatman marked this pull request as ready for review May 21, 2025 10:39
@hslatman hslatman requested a review from a team May 21, 2025 10:39
github.com/google/go-tpm v0.9.5
github.com/google/uuid v1.6.0
github.com/googleapis/gax-go/v2 v2.14.1
github.com/googleapis/gax-go/v2 v2.14.2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The go.mod changes seem unrelated go the linter fixes. Better to split this into separate PRs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The separate PRs exist, as created by Dependabot. I just didn't want to go through the hassle of (letting them) rebase, and combined them into this one. The bumps for each dependency are in separate commits, which I personally find granular enough.

@hslatman hslatman merged commit 0b0f351 into master May 21, 2025
13 checks passed
@hslatman hslatman deleted the herman/golangci-lint-v2-and-upgrades branch May 21, 2025 11:34
@hslatman
Copy link
Member Author

Thanks, @marten-seemann!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs triage Waiting for discussion / prioritization by team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants