Add explicit jboss-logging-processor reference to compiler plugin#576
Conversation
365f9b1 to
d6b4821
Compare
|
I agree with the change, but we should also remove it from |
|
We might have to do that in a follow up to avoid breaking dependents. |
|
FTR, this breaks Jandex build, because In SmallRye Fault Tolerance, I declare all annotation processors explicitly in the modules that require them. I'm honestly not sure we have to specify the |
|
Jandex should use JDK 17 or later to build. Also if it consumes this project then its build should be in CI for this project as well. |
|
It does. For testing, though, I also run the build with Java 8 (and 11, but that's not relevant here), and that's where it fails. |
|
The build should only be run on one later JDK (or else you're going to start hitting some awkward incompatibilities). Testing is (currently) best done by creating extra surefire and/or failsafe executions which run test on the older JDK. This also improves CI time considerably. This parent POM provides a mechanism to do this. |
JDK 23 changed the default annotation processing policy - https://inside.java/2024/06/18/quality-heads-up/#:~:text=Starting%20with%20JDK%2023%2C%20at,the%20default%20on%20JDK%2023.
This breaks tests in sr-health on JDK 23, so we need to declare the annotation processor explicitly.