feat(tunnels): group tunnels page by machine + add search#81
Merged
Conversation
A flat tunnel table forces users to scan the Machine column to mentally re-group rows; with multiple machines it gets unreadable fast. Group tunnels by machine into table sections, with a section header per machine showing name, status, tunnel count, and a per-section "+ Add tunnel" shortcut that pre-selects the machine in the create modal. The synthetic SSH-base row pins to the top of its machine's group; remaining tunnels sort alphabetically. Add a top-of-page search box that filters across tunnel name, subdomain, machine name, and either port — sections with no matches drop out automatically. Implementation notes: - Multiple <tbody> elements per <table> keeps column alignment intact (single visual table, multiple row groups). Section header is a colSpan=5 row inside each tbody. - Wrap tunnels/machines in useMemo so the grouping memo doesn't churn on every render — react-query gives us stable payloads but `?? []` was minting fresh arrays on each call. - openAddModal now takes an optional machineId; the page-header button passes nothing (the modal's existing machine picker takes over), the per-section button pre-fills it.
|
Unit tests run: 249 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #__
A flat tunnel table forces users to scan the Machine column to mentally re-group rows; with multiple machines it gets unreadable fast. Group tunnels by machine into table sections, with a section header per machine showing name, status, tunnel count, and a per-section "+ Add tunnel" shortcut that pre-selects the machine in the create modal. The synthetic SSH-base row pins to the top of its machine's group; remaining tunnels sort alphabetically. Add a top-of-page search box that filters across tunnel name, subdomain, machine name, and either port — sections with no matches drop out automatically.
Changes Made
Testing
Screenshots (if applicable)