chore: pin yamllint, golangci-lint#783
Merged
ramonpetgrave64 merged 6 commits intoslsa-framework:mainfrom Aug 2, 2024
Merged
Conversation
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Contributor
Author
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
ianlewis
reviewed
Jun 26, 2024
| @@ -0,0 +1,67 @@ | |||
| # | |||
Member
There was a problem hiding this comment.
AFAICT this is like a lock file. Should we perhaps use the Pipfile and Pipfile.lock formats instead?
Contributor
Author
There was a problem hiding this comment.
That's right, it is a lock file. I tried pipenv, but you first have to install it into the actions runner. Even actions/setp-python doesn't actually install pipenv. So I think we may as well continue using the requirements.txt.
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
Hayden-IO
approved these changes
Aug 2, 2024
Collaborator
Hayden-IO
left a comment
There was a problem hiding this comment.
Can’t speak to what’s correct for python dep pinning, but this seems good from what I’ve seen.
Hayden-IO
approved these changes
Aug 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pins the yaml-lint and golangci-lint dependency used in pre-submits.
This is to fix code-scanning alerts about unpinned dependencies
Testing Process
The pre-submit test that uses yamllint and golangci-lint passes