Skip to content

chore(deps): update npm dev (major)#753

Merged
laurentsimon merged 8 commits intoslsa-framework:mainfrom
ramonpetgrave64:renovate/npm-dev
Apr 3, 2024
Merged

chore(deps): update npm dev (major)#753
laurentsimon merged 8 commits intoslsa-framework:mainfrom
ramonpetgrave64:renovate/npm-dev

Conversation

@ramonpetgrave64
Copy link
Copy Markdown
Contributor

@ramonpetgrave64 ramonpetgrave64 commented Apr 2, 2024 •
edited
Loading

Redo of #654

  • Fix dev-dependencies related to es-lint that the renovate-bot couldn't auto-fix

  • a few commas automatically added by the new linter

  • use node20 for tests to avoid caompatibility warnings

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@typescript-eslint/parser@7.5.0',
npm WARN EBADENGINE   required: { node: '^18.18.0 || >=20.0.0' },
npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
npm WARN EBADENGINE }

renovate-bot and others added 7 commits April 2, 2024 19:19
@renovate-bot @ramonpetgrave64
chore(deps): update npm dev
c1d5a9b 
Signed-off-by: Mend Renovate <bot@renovateapp.com>
Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
@ramonpetgrave64
use node 20 for pre-submit.actions
dd66d99 
Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
@ramonpetgrave64
back to node 16
ccb8377 
Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
@ramonpetgrave64
install es-lint as dev dep, https://github.com/typescript-eslint/type…
e2b0775 
…script-eslint/blob/main/docs/getting-started/Quickstart.mdx

Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
@ramonpetgrave64
use eslint-prettier
6ea4ce7 
Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
@ramonpetgrave64
octokit deps require >=node18, so use node20
fd5604e 
Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
@ramonpetgrave64
rebuild
b13c4e6 
Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
@ramonpetgrave64 ramonpetgrave64 marked this pull request as ready for review April 2, 2024 19:33
@ramonpetgrave64
Copy link
Copy Markdown
Contributor Author

ramonpetgrave64 commented Apr 2, 2024

@laurentsimon

laurentsimon
laurentsimon approved these changes Apr 3, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@laurentsimon laurentsimon merged commit bcc39bf into slsa-framework:main Apr 3, 2024
@ramonpetgrave64 ramonpetgrave64 mentioned this pull request Apr 3, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laurentsimon laurentsimon laurentsimon approved these changes

@kpk47 kpk47 Awaiting requested review from kpk47

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ramonpetgrave64 @laurentsimon @renovate-bot