Skip to content

docs: Add Atsign-Foundation NoPorts to the Hall of Fame#3616

Merged
ianlewis merged 2 commits intoslsa-framework:mainfrom
cpswan:atsign-noports
May 14, 2024
Merged

docs: Add Atsign-Foundation NoPorts to the Hall of Fame#3616
ianlewis merged 2 commits intoslsa-framework:mainfrom
cpswan:atsign-noports

Conversation

@cpswan
Copy link
Contributor

@cpswan cpswan commented May 10, 2024

Summary

We're using generators for our Dart and Python release artifacts e.g.
https://github.com/atsign-foundation/noports/releases/tag/v5.2.1-rc1
https://github.com/atsign-foundation/noports/releases/tag/p0.4.9

Testing Process

N/A - docs update

Checklist

  • Review the contributing guidelines
  • Add a reference to related issues in the PR description.
  • Update documentation if applicable.
  • Add unit tests if applicable.
  • Add changes to the CHANGELOG if applicable.

Signed-off-by: Chris Swan <478926+cpswan@users.noreply.github.com>
@ramonpetgrave64
Copy link
Contributor

Welcome! You mentioned in #3617 to make this a multiline. I'd accept that. But just FYI, the "rich diff" view on github also makes the change clear. https://github.com/slsa-framework/slsa-github-generator/pull/3616/files?short_path=b335630#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5

@cpswan
Copy link
Contributor Author

cpswan commented May 10, 2024

@ramonpetgrave64 rather than a new PR are you OK with me pushing the multiline version for #3617 to this branch, in which case I'll convert this to draft for now and set it back when ready.

Also any thoughts on ordering: alphabetic or leave things how they are?

@ramonpetgrave64
Copy link
Contributor

Let's keep the order, but I'm okay with either the multiline or single line. Up to you.

@ramonpetgrave64
Copy link
Contributor

Looks good, but one more thing. You'll have to signoff on your commits. see the details on the DCO check.

Signed-off-by: Chris Swan <478926+cpswan@users.noreply.github.com>
@cpswan
Copy link
Contributor Author

cpswan commented May 11, 2024

@ramonpetgrave64 doh! Signoff now added to that last commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants