Skip to content

feat: Set cosign-repository input and env#2962

Merged
laurentsimon merged 8 commits intoslsa-framework:mainfrom
saisatishkarra:feat/cosign-repository-env
Nov 21, 2023
Merged

feat: Set cosign-repository input and env#2962
laurentsimon merged 8 commits intoslsa-framework:mainfrom
saisatishkarra:feat/cosign-repository-env

Conversation

@saisatishkarra
Copy link
Copy Markdown
Contributor

@saisatishkarra saisatishkarra commented Nov 10, 2023 •
edited
Loading

Solves: #2956

@saisatishkarra saisatishkarra force-pushed the feat/cosign-repository-env branch 2 times, most recently from d10f284 to e6a714e Compare November 10, 2023 17:33
laurentsimon
laurentsimon reviewed Nov 11, 2023
View reviewed changes
@saisatishkarra saisatishkarra force-pushed the feat/cosign-repository-env branch 2 times, most recently from 56108fb to db8fd1a Compare November 15, 2023 15:29
laurentsimon
laurentsimon reviewed Nov 15, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. A few questions and nits, but looking good!

@saisatishkarra saisatishkarra mentioned this pull request Nov 15, 2023
Open
@saisatishkarra
Copy link
Copy Markdown
Contributor Author

saisatishkarra commented Nov 15, 2023 •
edited by laurentsimon
Loading

@laurentsimon Is there a way to autogenerate the readme with updated paramters for the workflow? If so, can you guide on How-To?

@laurentsimon
Copy link
Copy Markdown
Collaborator

laurentsimon commented Nov 15, 2023

@laurentsimon Is there a way to autogenerate the readme with updated paramters for the workflow? If so, can you guide on How-To?

There's no auto-generate :/
You can edit the README directly and it should work. We may have a presubmit https://github.com/slsa-framework/slsa-github-generator/blob/main/.github/workflows/scripts/pre-submit.markdown/markdown-toc.sh which runs the markdown-toc command (it's javascript package). It should not be necessary in your case because you're not updating the table of content.

Does that help?

@saisatishkarra saisatishkarra force-pushed the feat/cosign-repository-env branch from e93891b to ac1d9c3 Compare November 15, 2023 18:05
@saisatishkarra
feat: Set cosign-repository input and env
e2fae1b 
Signed-off-by: saisatishkarra <saisatish.karra@konghq.com>
@saisatishkarra
Add provenance store auth parameters
db81319 
Signed-off-by: saisatishkarra <saisatish.karra@konghq.com>
@saisatishkarra
fix review comments
5c0b0e7 
Signed-off-by: saisatishkarra <saisatish.karra@konghq.com>
@saisatishkarra saisatishkarra force-pushed the feat/cosign-repository-env branch from ac1d9c3 to 5c0b0e7 Compare November 15, 2023 18:05
laurentsimon
laurentsimon reviewed Nov 15, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ianlewis can you take a second look before we merge?

@saisatishkarra saisatishkarra force-pushed the feat/cosign-repository-env branch from 5fa60e6 to 529b570 Compare November 16, 2023 14:19
@saisatishkarra
fix typos
df805e8 
Signed-off-by: saisatishkarra <saisatish.karra@konghq.com>
@saisatishkarra saisatishkarra force-pushed the feat/cosign-repository-env branch from 529b570 to df805e8 Compare November 16, 2023 14:22
@saisatishkarra
Copy link
Copy Markdown
Contributor Author

saisatishkarra commented Nov 16, 2023

cc: @laurentsimon / @ianlewis for some eyes!! Looking to make similar changes on the verifier with some guidance on expected direction!

laurentsimon
laurentsimon approved these changes Nov 17, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@laurentsimon
Copy link
Copy Markdown
Collaborator

laurentsimon commented Nov 17, 2023

Take a look at the linter failures. Should be easy to fix

@saisatishkarra
fix indentation
77e4a28 
Signed-off-by: saisatishkarra <saisatish.karra@konghq.com>
@saisatishkarra saisatishkarra force-pushed the feat/cosign-repository-env branch from 3461064 to 77e4a28 Compare November 20, 2023 17:03
@saisatishkarra
Copy link
Copy Markdown
Contributor Author

saisatishkarra commented Nov 20, 2023

Take a look at the linter failures. Should be easy to fix

Fixed linting issues and indentation. Waiting for the checks to run!!

@laurentsimon laurentsimon enabled auto-merge (squash) November 20, 2023 17:57
@saisatishkarra
fix shell check warnings
1f4b072 
Signed-off-by: saisatishkarra <saisatish.karra@konghq.com>
auto-merge was automatically disabled November 20, 2023 22:46

Head branch was pushed to by a user without write access

@saisatishkarra saisatishkarra force-pushed the feat/cosign-repository-env branch from 048292d to 1f4b072 Compare November 20, 2023 22:46
ianlewis
ianlewis approved these changes Nov 21, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@ianlewis ianlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laurentsimon @ianlewis
Update internal/builders/container/README.md
34f09f3 
Co-authored-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
@laurentsimon laurentsimon enabled auto-merge (squash) November 21, 2023 03:46
@laurentsimon laurentsimon merged commit 23a2d52 into slsa-framework:main Nov 21, 2023
@laurentsimon laurentsimon mentioned this pull request Nov 22, 2023
Closed
@saisatishkarra saisatishkarra mentioned this pull request Nov 22, 2023
Closed
@laurentsimon laurentsimon mentioned this pull request Nov 23, 2023
Closed
@curiositycasualty
Copy link
Copy Markdown

curiositycasualty commented Apr 12, 2024

Thanks for your time spent on this @laurentsimon & @ianlewis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ianlewis ianlewis ianlewis approved these changes

@laurentsimon laurentsimon laurentsimon approved these changes

@asraa asraa Awaiting requested review from asraa

@joshuagl joshuagl Awaiting requested review from joshuagl

@kpk47 kpk47 Awaiting requested review from kpk47

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@saisatishkarra @laurentsimon @curiositycasualty @ianlewis