CTRL + C: try to quit gracefully#835
Merged
archisman-panigrahi merged 1 commit intoslgobinath:masterfrom Feb 19, 2026
Merged
Conversation
4689d29 to
9e02579
Compare
Collaborator
|
Thanks for the PR. I cannot find any change in behavior. What should I look for? |
Collaborator
Author
|
The difference is only visible when running with This does have the side-effect that it will e.g. also write to the session file when that is enabled, which I think it should. |
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make the signal handler go through the normal
quitcodepath on the first call.The second call will force-quit like before, if the app completely hangs. (This is a common convention).