typing: fix incorrect typing for locale#833
Merged
archisman-panigrahi merged 1 commit intoslgobinath:masterfrom Jan 19, 2026
Merged
typing: fix incorrect typing for locale#833archisman-panigrahi merged 1 commit intoslgobinath:masterfrom
archisman-panigrahi merged 1 commit intoslgobinath:masterfrom
Conversation
Collaborator
|
Is this ready? |
Collaborator
Author
Yes, it is. |
Collaborator
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This was incorrectly typed as
strbefore, when it was actually a gettext.GNUTranslations instance (with aNullTranslationsbase class).This makes the tests just slightly more annoying, as now we have to mock that class too - but it was just luck that it worked before.