#354: Add #selector rule to the grammar#357
Merged
adityatrivedi merged 4 commits intomasterfrom Apr 3, 2016
Merged
Conversation
|
|
||
| // GRAMMAR OF AN ARGUMENT NAME | ||
| argumentNames : argumentName argumentNames? ; | ||
| argumentName: (identifier | '_') ':'? ; |
Member
There was a problem hiding this comment.
Add a comment indicating that this line differs from the Swift Language Reference (there are lots of examples in this file).
Member
|
👍 🎉 |
0ef605f to
333e140
Compare
Add comments for discrepancies with Apple's Swift Language Reference Guide.
333e140 to
1da3945
Compare
|
|
||
| // GRAMMAR OF AN ARGUMENT NAME | ||
| argumentNames : argumentName argumentNames? ; | ||
| argumentName: (identifier | '_') ':'? ; // Swift Language Reference has argumentName → identifier : |
Member
There was a problem hiding this comment.
Is the ':' supposed to be optional? (another deviation from the Swift Language Reference)
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #354. The
#selectormacro is a new feature introduced with Swift 2.2.The grammar needs to be updated to incorporate new language features that have been added in Swift 2.2.