This repository was archived by the owner on Jun 15, 2023. It is now read-only.
Update dependencies and InputType mapping to remove obsolete feature #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safareli
reviewed
Dec 7, 2017
Contributor
safareli
left a comment
There was a problem hiding this comment.
Thanks for raising the issue. I have desired changes to our deps so we shuold update versions.
and also remove DateTime node from here too.
(looks like you have remove your fork this might help https://stackoverflow.com/questions/20977530/recover-a-commit-sent-as-a-pull-request-from-a-deleted-fork-on-github)
| "package.json" | ||
| ], | ||
| "dependencies": { | ||
| "purescript-halogen-datepicker": "^0.1.0", |
Contributor
There was a problem hiding this comment.
made v1.0.0 release there so it could be updated to "^1.0.0"
| ], | ||
| "dependencies": { | ||
| "purescript-halogen-datepicker": "^0.1.0", | ||
| "purescript-browserfeatures": "^4.0.0", |
Contributor
There was a problem hiding this comment.
made v5.0.0 release there so it could be updated to "^5.0.0"
| case it of | ||
| IT.Color → HP.InputColor | ||
| IT.Date → HP.InputDate | ||
| IT.DateTime → HP.InputDatetime |
Contributor
There was a problem hiding this comment.
We can remove the type from here too
Merged
Contributor
Author
|
I wasn't able to recover the fork, so I've opened a new PR here: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to use this in a component in a Halogen project, but because Halogen has a new major version number (2 -> 3), this package is incompatible. I bumped the major version number and found that it will fail to build for two reasons:
This package relies on
purescript-halogen-datepicker, which itself is still on Halogen 2.1.0.This can be resolved with this pull request to update that package's dependencies.
The
InputType.pursfile maps browser input types to Halogen properties.Halogen 3.0.0 removes an obsolute browser input type, "datetime", and keeps the still-supported one, "datetime-local." However, the
browserfeaturespackage has not been updated to remove that obsolete feature -- as noted in this issue on thebrowserfeaturesrepo. In this package, the browser features are mapped to Halogen properties, including the now-removedDateTime.In this PR I've fixed this by mapping the browserfeatures
DateTimetype to the HalogenDateTimeLocaltype. However, since SlamData also owns the browserfeatures package, I suppose you could just remove the type from that package, too, and then delete the line altogether in this package.This package can't be updated until the two issues above are resolved, but at that point this will again become usable in Halogen 3.0.0 projects.