feat: implement automatic recovery for hh_client#197
Merged
mszabo-wikia merged 2 commits intomasterfrom Mar 27, 2026
Merged
Conversation
It's possible for `hh_client` (and `hh_server`) to be terminated if they are being used via an externally managed container. Currently we cannot recover from this without the user manually refreshing their VSCode window. So implement automatic recovery when the language server or the backing `hh_server` process crashes, alongside helpful notifications informing the user of this.
tgrieger-sf
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's possible for
hh_client(andhh_server) to be terminated if they are being used via an externally managed container. Currently we cannot recover from this without the user manually refreshing their VSCode window. So implement automatic recovery when the language server or the backinghh_serverprocess crashes, alongside helpful notifications informing the user of this.Testing
Replaced
hh_clientwith an executable that exits with an error, then killedhh_clientprocesses to trigger the automatic restart logic, then eventually swapped the realhh_clientback in.