Skip to content

slack-vitess-r14.0.5:Add vstream metrics to vtgate (#13098)#84

Merged
timvaillancourt merged 1 commit intoslack-vitess-r14.0.5from
pr-13098-slack-vitess-r14.0.5
May 20, 2023
Merged

slack-vitess-r14.0.5:Add vstream metrics to vtgate (#13098)#84
timvaillancourt merged 1 commit intoslack-vitess-r14.0.5from
pr-13098-slack-vitess-r14.0.5

Conversation

@twthorn
Copy link
Copy Markdown

@twthorn twthorn commented May 19, 2023

Description

Upstream backport of vitessio#13098

Related Issue(s)

vitessio#13099

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@twthorn twthorn requested a review from a team as a code owner May 19, 2023 23:34
@salesforce-cla
Copy link
Copy Markdown

Thanks for the contribution! Before we can merge this, we need @twthorn to sign the Salesforce Inc. Contributor License Agreement.

* Add vstream metrics to vtgate

Signed-off-by: twthorn <thomaswilliamthornton@gmail.com>

* Update unit test name and use cell variable

Signed-off-by: twthorn <thomaswilliamthornton@gmail.com>

* Reset metrics for TestVStreamsCreatedAndLagMetrics, fix data race issue

Signed-off-by: twthorn <thomaswilliamthornton@gmail.com>

---------

Signed-off-by: twthorn <thomaswilliamthornton@gmail.com>
@twthorn twthorn force-pushed the pr-13098-slack-vitess-r14.0.5 branch from c37513b to 34a3529 Compare May 19, 2023 23:56
Copy link
Copy Markdown

@timvaillancourt timvaillancourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@timvaillancourt timvaillancourt merged commit 21b4c7f into slack-vitess-r14.0.5 May 20, 2023
@timvaillancourt timvaillancourt deleted the pr-13098-slack-vitess-r14.0.5 branch May 20, 2023 22:11
@tanjinx tanjinx changed the title Add vstream metrics to vtgate (#13098) slack-vitess-r14.0.5:Add vstream metrics to vtgate (#13098) May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants