Skip to content

Revert upstream 13623: remove the call of verifyAllTabletsReachable in PRS#648

Merged
timvaillancourt merged 10 commits intoslack-19.0from
revert-prs-v18
May 7, 2025
Merged

Revert upstream 13623: remove the call of verifyAllTabletsReachable in PRS#648
timvaillancourt merged 10 commits intoslack-19.0from
revert-prs-v18

Conversation

@tanjinx
Copy link
Copy Markdown

@tanjinx tanjinx commented Apr 24, 2025 •
edited
Loading

Description

Revert Improvements to PRS #13623

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@github-actions github-actions bot added this to the v19.0.7 milestone Apr 24, 2025
@tanjinx tanjinx changed the title Revert prs v18 Revert the call of verifyAllTabletsReachable in PRS Apr 24, 2025
tanjinx added 8 commits May 5, 2025 09:42
@tanjinx
Revert "Improvements to PRS (vitessio#13622)"
9a6188f 
This reverts commit 2ffcc26.

Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>
@tanjinx
fix test
c265e48 
Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>
@tanjinx
fix reparent library
9f7b2ba 
Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>
@tanjinx
fix tests
bacfcd9 
Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>
@tanjinx
remove empty line
2a5c572 
Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>
@tanjinx
fix tests
91894d9 
Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>
@tanjinx
fix tests
23f5753 
Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>
@tanjinx
undo errorgroup changes
439a11e 
Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>
tanjinx added 2 commits May 5, 2025 10:22
@tanjinx
undo PrimaryTermStartTime changes
ba74ebd 
Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>
@tanjinx
fix test
95f16a7 
Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>
@tanjinx tanjinx marked this pull request as ready for review May 5, 2025 19:37
@tanjinx tanjinx requested a review from a team as a code owner May 5, 2025 19:37
@tanjinx tanjinx changed the title Revert the call of verifyAllTabletsReachable in PRS Revert upstream 13623: remove the call of verifyAllTabletsReachable in PRS May 5, 2025
@timvaillancourt timvaillancourt merged commit ec38da5 into slack-19.0 May 7, 2025
163 of 165 checks passed
@timvaillancourt timvaillancourt deleted the revert-prs-v18 branch May 7, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@timvaillancourt timvaillancourt timvaillancourt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

upstream-revert An upstream revert v18-backport v19

Projects

None yet

Milestone

v19.0.7

Development

Successfully merging this pull request may close these issues.

2 participants

@tanjinx @timvaillancourt