Skip to content

Backport vstream copy fixes#632

Merged
tanjinx merged 5 commits intoslack-19.0from
tthornton_backport-vstream-copy-PRs
Apr 8, 2025
Merged

Backport vstream copy fixes#632
tanjinx merged 5 commits intoslack-19.0from
tthornton_backport-vstream-copy-PRs

Conversation

@twthorn
Copy link
Copy Markdown

@twthorn twthorn commented Apr 1, 2025 •
edited
Loading

Description

Backport two PRs related to VStream COPY

  1. VStream API: validate that last PK has fields defined vitessio/vitess#16478
  2. (This one was actually backported in 19.0.7 version so it has no diff applied) VReplication: Align VReplication and VTGate VStream Retry Logic vitessio/vitess#17783

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@twthorn twthorn requested a review from a team as a code owner April 1, 2025 17:50
@salesforce-cla
Copy link
Copy Markdown

salesforce-cla bot commented Apr 1, 2025

Thanks for the contribution! Before we can merge this, we need @rohit-nayak-ps @mattlord to sign the Salesforce Inc. Contributor License Agreement.

@github-actions github-actions bot added this to the v19.0.7 milestone Apr 1, 2025
@twthorn twthorn force-pushed the tthornton_backport-vstream-copy-PRs branch from fdc90df to f91b4c4 Compare April 1, 2025 17:54
@salesforce-cla
Copy link
Copy Markdown

salesforce-cla bot commented Apr 1, 2025

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Thomas Thornton <t***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request.

@twthorn twthorn force-pushed the tthornton_backport-vstream-copy-PRs branch from f91b4c4 to 6a3b674 Compare April 1, 2025 17:55
@twthorn twthorn changed the title Tthornton backport vstream copy p rs Backport vstream copy fixes Apr 2, 2025
@tanjinx tanjinx merged commit 17ff5a2 into slack-19.0 Apr 8, 2025
162 of 165 checks passed
@tanjinx tanjinx deleted the tthornton_backport-vstream-copy-PRs branch April 8, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tanjinx tanjinx tanjinx approved these changes

Assignees

No one assigned

Labels

cla:missing v22-backport

Projects

None yet

Milestone

v19.0.7

Development

Successfully merging this pull request may close these issues.

2 participants

@twthorn @tanjinx