[v15.0.5]: Backport upstream 13856 - reshard state check fix#322
Closed
tanjinx wants to merge 4 commits intoslack-15.0from
Closed
[v15.0.5]: Backport upstream 13856 - reshard state check fix#322tanjinx wants to merge 4 commits intoslack-15.0from
tanjinx wants to merge 4 commits intoslack-15.0from
Conversation
Signed-off-by: 'Tanjin Xu' <tanjin.xu@slack-corp.com>
Signed-off-by: 'Tanjin Xu' <tanjin.xu@slack-corp.com>
vmogilev
approved these changes
May 4, 2024
|
@tanjinx this PR is including the git state of the upstream PR How did you do the backport and is it possible to use |
timvaillancourt
suggested changes
May 4, 2024
timvaillancourt
left a comment
There was a problem hiding this comment.
Left comment about git history/backport method
4 tasks
|
Replacing this with #377 which uses |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
backport vitessio#13856
fixing confusing resharding message https://jira.tinyspeck.com/browse/DRE-9167
And need another one vitessio#13010 for the missing null pointer check.
v14.0.5 backport #321
Related Issue(s)
Checklist
Deployment Notes