fixed #51 for env variables in payload json file#71
Merged
filmaj merged 1 commit intoslackapi:mainfrom Mar 7, 2022
Merged
Conversation
|
|
filmaj
approved these changes
Mar 7, 2022
Contributor
filmaj
left a comment
There was a problem hiding this comment.
Hey this is great, thanks so much!
I think this repo needs its settings tweaked as I don't think the integration tests ran on this PR (probably because the repo origin for the PR is not the root repo, for security reasons). Perhaps @stevengill you can enable repo maintainers to allow for PRs to run tests if we approve? I'd like to make sure that the integration test for payload file successfully interpolated the github event data into the message post to ensure this is working properly.
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Describe the goal of this PR. Mention any related Issue numbers.
Fixes #51
Added Code for accessing github context variables in payload json file
Updated Valid TestCase
Requirements (place an
xin each[ ])