Skip to content

Use https proxy agent#132

Merged
seratch merged 2 commits intoslackapi:mainfrom
EHitchcockIAG:use-https-proxy-agent
Oct 11, 2022
Merged

Use https proxy agent#132
seratch merged 2 commits intoslackapi:mainfrom
EHitchcockIAG:use-https-proxy-agent

Conversation

@EHitchcockIAG
Copy link
Contributor

@EHitchcockIAG EHitchcockIAG commented Sep 30, 2022

Summary

Add an https-proxy-agent when HTTP proxy is used by action consumer and webhook uses HTTPS.
Issue: #131

This pull request resolves #131

Requirements (place an x in each [ ])

@seratch seratch added this to the 1.23 milestone Sep 30, 2022
@seratch seratch added the enhancement New feature or request label Sep 30, 2022
@seratch seratch self-assigned this Sep 30, 2022
Copy link
Contributor

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seratch seratch requested review from filmaj and stevengill October 3, 2022 22:31
@seratch
Copy link
Contributor

seratch commented Oct 3, 2022

@stevengill what do you think?

Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as this works for you @EHitchcockIAG , LGTM! Wondering how I can test this...

@seratch
Copy link
Contributor

seratch commented Oct 11, 2022

This should be great, let me merge this PR now

@seratch seratch merged commit acb114f into slackapi:main Oct 11, 2022
@EHitchcockIAG EHitchcockIAG deleted the use-https-proxy-agent branch December 16, 2022 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Axios Post Request fails behind HTTP Proxy

3 participants