Skip to content

feat(style): add style.Separator() for hyphen consistency#430

Merged
srtaalej merged 4 commits intomainfrom
ale-style-separator
Mar 23, 2026
Merged

feat(style): add style.Separator() for hyphen consistency#430
srtaalej merged 4 commits intomainfrom
ale-style-separator

Conversation

@srtaalej
Copy link
Copy Markdown
Contributor

@srtaalej srtaalej commented Mar 23, 2026 •
edited
Loading

Changelog

n/a

Summary

This PR adds style.Separator() function that returns an hyphen (" - ") for use as a consistent delimiter between option names and descriptions in prompts. Replace hardcoded em-dash string in forms.go with style.Separator() for consistency with other style functions

Screenshot 2026-03-23 at 12 12 41 PM

Test plan

make test testdir=internal/iostreams                                
make test testdir=internal/style
make lint

Requirements

@srtaalej srtaalej added this to the Next Release milestone Mar 23, 2026
@srtaalej srtaalej self-assigned this Mar 23, 2026
@srtaalej srtaalej requested a review from a team as a code owner March 23, 2026 16:13
@srtaalej srtaalej added enhancement M-T: A feature request for new functionality experiment Experimental feature accessed behind the --experiment flag or toggle semver:patch Use on pull requests to describe the release version increment labels Mar 23, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.28%. Comparing base (cb30df8) to head (2422f06).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
- Coverage   70.30%   70.28%   -0.03%     
==========================================
  Files         220      220              
  Lines       18480    18482       +2     
==========================================
- Hits        12993    12990       -3     
  Misses       4316     4316              
- Partials     1171     1176       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mwbrooks
mwbrooks reviewed Mar 23, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to standardize the separator through a function and I like that you're putting this up as an isolated pull request! 🙇🏻

I've left a few suggestions in the comments below 🧠

srtaalej and others added 2 commits March 23, 2026 12:56
@srtaalej @mwbrooks
Update internal/style/style.go
a3a4f5f 
Co-authored-by: Michael Brooks <mbrooks@slack-corp.com>
@srtaalej
test: add test case for hyphen separator func
7d92bea
@srtaalej srtaalej requested review from mwbrooks and zimeg March 23, 2026 17:11
mwbrooks
mwbrooks approved these changes Mar 23, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Looks good @srtaalej! - 🎉

⚠️ Before merging, please update the PR title and description from em-dash to hyphen so that our CHANGELOGs looks correct.

@srtaalej srtaalej merged commit ba1b784 into main Mar 23, 2026
8 checks passed
@srtaalej srtaalej deleted the ale-style-separator branch March 23, 2026 18:48
@mwbrooks mwbrooks changed the title feat(style): add style.Separator for non ASCII em-dash feat(style): add style.Separator() for hyphen consistency Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mwbrooks mwbrooks mwbrooks approved these changes

@zimeg zimeg Awaiting requested review from zimeg

Assignees

@srtaalej srtaalej

Labels

enhancement M-T: A feature request for new functionality experiment Experimental feature accessed behind the --experiment flag or toggle semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

2 participants

@srtaalej @mwbrooks