refactor(experiment): separate huh and lipgloss changes of charm#411
refactor(experiment): separate huh and lipgloss changes of charm#411
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #411 +/- ##
=======================================
Coverage 68.46% 68.47%
=======================================
Files 218 218
Lines 18058 18063 +5
=======================================
+ Hits 12364 12368 +4
- Misses 4538 4539 +1
Partials 1156 1156 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mwbrooks
left a comment
There was a problem hiding this comment.
✅ Thank you so much for breaking these out! Confidence toward a huh release is feeling higher, scope is smaller, and focus is stronger 💪🏻 I imagine this was a tedious task, but I appreciate it! 🙇🏻
❓ Left a non-blocking question - just something to think about but not take action on right now.
|
|
||
| Below is a list of updates related to experiments. | ||
|
|
||
| - **March 2026**: Split the `charm` experiment into more beautiful `huh` prompts and prettier `lipgloss` styles for ongoing change. |
| @@ -14,19 +14,29 @@ | |||
|
|
|||
| package iostreams | |||
There was a problem hiding this comment.
question: Long-term, is there a more appropriate filename than charm.go? As a new maintainer I may not connect that two packages - huh and lipgloss - are from the same group charm. I see the newForm constructor uses both, but I wonder if we have an opportunity for a huh.go instead?
There was a problem hiding this comment.
@mwbrooks I share this feeling. The terms "charm" or "huh" or "lipgloss" are meaningful for package imports but we might want to refactor this into a different packages once experiments conclude:
internal/iostreams/charm.go->internal/iostreams/forms.go
I'm not against huh.go either but it takes me a second to realize it's asking for input the same 😉
There was a problem hiding this comment.
forms.go is a good choice as well!
There was a problem hiding this comment.
@mwbrooks Cool cool! I'll hold off on changing that for another PR but it might be a good step toward the conclusions of huh experiment!
…m-huh-lipgloss # Conflicts: # internal/iostreams/charm.go
|
@mwbrooks Thank you for sharing your thoughts on these changes overall 🍀 ✨ We're bringing the |
Changelog
Summary
This PR separates the
huhandlipglosschanges ofcharmexperiment into separate experiments to keep changes of prompts and style ordered toward stable release 🎁Preview
Before changes:
After changes:
Requirements