Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #403 +/- ##
==========================================
- Coverage 68.15% 68.12% -0.03%
==========================================
Files 218 218
Lines 18020 18020
==========================================
- Hits 12281 12277 -4
- Misses 4582 4586 +4
Partials 1157 1157 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| # VHS demo recordings | ||
| demos/ |
There was a problem hiding this comment.
question(non-blocking): Curious if you considered having our VHS demos checked into version control? Just curious if we'd ever want to re-generate older recordings to show an updated UI.
There was a problem hiding this comment.
📸 Such an interesting idea! Without knowing good practices to this I left it for later thinking to be honest-
I'd be so curious to versioning .tape files with the docs 📚
Our hidden docgen command might be extended to require vhs to regenerate all recordings with the latest release perhaps? Would love to learn recommendations to this and thoughts from @lukegalbraithrussell!
There was a problem hiding this comment.
Our hidden docgen command might be extended to require vhs to regenerate all recordings with the latest release perhaps?
You nailed it. This is where my mind was going as well. Since the docs are part of the CLI repo and updated on each release, we have an opportunity to add rich, interactive gifs to the docs website.
|
@mwbrooks Exciting times to find perhaps more polish to PRs! 🍀 ✨ Let's merge this with background thinking to how we might surface these demos in documentation. I'm excited to experiment with workflows related to this 🚢 💨 |
Changelog
Summary
This PR adds a
claudeskill to record demos for PR previews using thevhspackage.Preview
📸 Example of generated "tape" and GIF - the app existed ahead of time which might be useful for intricate setups:
Requirements