Fix #808 Improve the stability of mock servers in tests#929
Merged
seratch merged 1 commit intoslackapi:mainfrom Jan 27, 2021
Merged
Fix #808 Improve the stability of mock servers in tests#929seratch merged 1 commit intoslackapi:mainfrom
seratch merged 1 commit intoslackapi:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #929 +/- ##
==========================================
+ Coverage 86.46% 86.48% +0.02%
==========================================
Files 51 51
Lines 4618 4618
==========================================
+ Hits 3993 3994 +1
+ Misses 625 624 -1
Continue to review full report at Codecov.
|
stevengill
approved these changes
Jan 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request improves the stability of mock servers in the unit tests - fixes #808 This benefits test execution on macOS a lot. After merging this PR, mock servers in tests run in separate processes (utilizing multiprocessing over threading). For the CI build environment, we continue using threading for the runtime as before (because it's more stable when running on GitHub Actions runtime).
Category (place an
xin each of the[ ])/docs-src(Documents, have you run./docs.sh?)/docs-src-v2(Documents, have you run./docs-v2.sh?)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements (place an
xin each[ ])python setup.py validateafter making the changes.