Skip to content

Add two admin APIs with binary response support#865

Merged
seratch merged 1 commit intoslackapi:mainfrom
seratch:new-apis-2020-10
Nov 6, 2020
Merged

Add two admin APIs with binary response support#865
seratch merged 1 commit intoslackapi:mainfrom
seratch:new-apis-2020-10

Conversation

@seratch
Copy link
Copy Markdown
Contributor

@seratch seratch commented Oct 30, 2020 •
edited
Loading

Summary

This pull request adds two admin API support:

  • admin.analytics.getFile
  • admin.apps.clearResolution

admin.analytics.getFile API is completely different from the existing ones as it doesn't return text response body. To support this endpoint, I've updated the base clients and response classes.

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (Web API client)
  • slack_sdk.webhook.WebhookClient (Incoming Webhook, response_url sender)
  • slack_sdk.models (UI component builders)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.rtm.RTMClient (RTM client)
  • slack_sdk.signature (Request Signature Verifier)
  • /docs-src (Documents, have you run ./docs.sh?)
  • /docs-src-v2 (Documents, have you run ./docs-v2.sh?)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python setup.py validate after making the changes.

@seratch seratch added enhancement M-T: A feature request for new functionality web-client Version: 3x labels Oct 30, 2020
@seratch seratch added this to the 3.0.0 milestone Oct 30, 2020
@seratch seratch self-assigned this Oct 30, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 30, 2020 •
edited
Loading

Codecov Report

Merging #865 (984c993) into main (c2cfa4f) will decrease coverage by 0.14%.
The diff coverage is 57.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #865      +/-   ##
==========================================
- Coverage   76.43%   76.28%   -0.15%     
==========================================
  Files          35       35              
  Lines        3204     3226      +22     
==========================================
+ Hits         2449     2461      +12     
- Misses        755      765      +10
Impacted Files Coverage Δ
slack_sdk/web/legacy_client.py 35.69% <33.33%> (-0.03%) ⬇️
slack_sdk/web/legacy_slack_response.py 92.42% <61.53%> (-7.58%) ⬇️
slack_sdk/web/legacy_base_client.py 87.93% <71.42%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8a94bd...a1825fa. Read the comment docs.

@seratch
Add two admin APIs with binary response support
a1825fa 
* admin.analytics.getFile
* admin.apps.clearResolution
@seratch seratch merged commit bba0476 into slackapi:main Nov 6, 2020
@seratch seratch deleted the new-apis-2020-10 branch November 6, 2020 22:42
@seratch seratch mentioned this pull request Mar 22, 2021
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mwbrooks mwbrooks Awaiting requested review from mwbrooks

@stevengill stevengill Awaiting requested review from stevengill

@aoberoi aoberoi Awaiting requested review from aoberoi

@misscoded misscoded Awaiting requested review from misscoded

Assignees

@seratch seratch

Labels

enhancement M-T: A feature request for new functionality Version: 3x web-client

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

1 participant

@seratch