Skip to content

Fix #846 RTMClient does not pass timeout value to WebClient#857

Merged
seratch merged 1 commit intoslackapi:mainfrom
seratch:issue-846-rtm-timeouts
Oct 21, 2020
Merged

Fix #846 RTMClient does not pass timeout value to WebClient#857
seratch merged 1 commit intoslackapi:mainfrom
seratch:issue-846-rtm-timeouts

Conversation

@seratch
Copy link
Copy Markdown
Contributor

@seratch seratch commented Oct 21, 2020

Summary

This pull request fixes #846

Category (place an x in each of the [ ])

  • slack.web.WebClient (Web API client)
  • slack.webhook.WebhookClient (Incoming Webhook, response_url sender)
  • slack.web.classes (UI component builders)
  • slack.rtm.RTMClient (RTM client)
  • Documents
  • Others

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python setup.py validate after making the changes.

@seratch seratch added Version: 2x bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented rtm-client labels Oct 21, 2020
@seratch seratch added this to the 2.9.3 milestone Oct 21, 2020
@seratch seratch self-assigned this Oct 21, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 21, 2020 •
edited
Loading

Codecov Report

Merging #857 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #857   +/-   ##
=======================================
  Coverage   87.01%   87.01%           
=======================================
  Files          30       30           
  Lines        3797     3797           
  Branches      340      340           
=======================================
  Hits         3304     3304           
  Misses        344      344           
  Partials      149      149
Impacted Files Coverage Δ
slack/rtm/client.py 83.82% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 580a5ab...e1eebb3. Read the comment docs.

@seratch seratch merged commit f8ccc04 into slackapi:main Oct 21, 2020
@seratch seratch deleted the issue-846-rtm-timeouts branch October 21, 2020 20:34
@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mwbrooks mwbrooks mwbrooks approved these changes

@stevengill stevengill stevengill approved these changes

@misscoded misscoded Awaiting requested review from misscoded

Assignees

@seratch seratch

Labels

bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented rtm-client Version: 2x

Projects

None yet

Milestone

2.9.3

Development

Successfully merging this pull request may close these issues.

RTMClient does not pass timeout value to WebClient

3 participants

@seratch @mwbrooks @stevengill