Fix #1310 Add admin.conversations.bulk{Archive|Delete|Move} API method support#1311
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1311 +/- ##
==========================================
- Coverage 85.79% 85.37% -0.42%
==========================================
Files 84 111 +27
Lines 7861 11334 +3473
==========================================
+ Hits 6744 9676 +2932
- Misses 1117 1658 +541
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
The integration test does not work. I will update the code later on |
|
The error: As the Java code does, test code has to wait until "action_already_in_progress" error dispappears. |
|
I was going to contribute to the test code but I have to work on other tasks today. @WilliamBergamin can you fix it when you have a chance? No rush at all |
seratch
left a comment
There was a problem hiding this comment.
Code changes, unit tests, document changes are all great. The e2e test does not work
|
@seratch I partially set up my local with the requirements of the integration tests, I've modified the tests and they pass on my end now |
seratch
left a comment
There was a problem hiding this comment.
Thanks for updating the test. I've confirmed that the test works for me too. Looks great to me
Summary
This pull request resolves slackapi/java-slack-sdk#1087
Note: I did not run the integration tests locally
Fixes #1310
Category
/docs-src(Documents, have you run./scripts/docs.sh?)/docs-src-v2(Documents, have you run./scripts/docs-v2.sh?)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.