Skip to content

Add more revert to #1269#1271

Merged
seratch merged 1 commit intoslackapi:mainfrom
seratch:more-to-pr1269
Oct 4, 2022
Merged

Add more revert to #1269#1271
seratch merged 1 commit intoslackapi:mainfrom
seratch:more-to-pr1269

Conversation

@seratch
Copy link
Copy Markdown
Contributor

@seratch seratch commented Sep 30, 2022

Summary

This pull request applies one more revert change to #1269

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 3x socket-mode labels Sep 30, 2022
@seratch seratch added this to the 3.18.5 milestone Sep 30, 2022
@seratch seratch self-assigned this Sep 30, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 30, 2022

Codecov Report

Merging #1271 (1fef168) into main (d558afa) will decrease coverage by 0.08%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main    #1271      +/-   ##
==========================================
- Coverage   86.16%   86.07%   -0.09%     
==========================================
  Files          84       84              
  Lines        7771     7779       +8     
==========================================
  Hits         6696     6696              
- Misses       1075     1083       +8
Impacted Files Coverage Δ
slack_sdk/socket_mode/builtin/internals.py 73.81% <83.33%> (+0.93%) ⬆️
slack_sdk/socket_mode/builtin/connection.py 64.44% <0.00%> (-2.60%) ⬇️
slack_sdk/socket_mode/builtin/client.py 89.63% <0.00%> (-0.61%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

yardensachs
yardensachs approved these changes Oct 4, 2022
View reviewed changes
Copy link
Copy Markdown

@yardensachs yardensachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled the branch and no more issues

@seratch
Copy link
Copy Markdown
Contributor Author

seratch commented Oct 4, 2022

@yardensachs Thanks a lot for checking the behavior on your end!

@seratch seratch merged commit b34c806 into slackapi:main Oct 4, 2022
@seratch seratch deleted the more-to-pr1269 branch October 4, 2022 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@yardensachs yardensachs yardensachs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@seratch seratch

Labels

bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented socket-mode Version: 3x

Projects

None yet

Milestone

3.18.5

Development

Successfully merging this pull request may close these issues.

2 participants

@seratch @yardensachs