Fix #1200 Model to_dict doesn't handle tuple sequences#1206
Merged
seratch merged 2 commits intoslackapi:mainfrom May 3, 2022
Merged
Fix #1200 Model to_dict doesn't handle tuple sequences#1206seratch merged 2 commits intoslackapi:mainfrom
seratch merged 2 commits intoslackapi:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1206 +/- ##
==========================================
- Coverage 86.51% 86.50% -0.01%
==========================================
Files 110 110
Lines 10872 10872
==========================================
- Hits 9406 9405 -1
- Misses 1466 1467 +1
Continue to review full report at Codecov.
|
filmaj
approved these changes
May 3, 2022
Contributor
filmaj
left a comment
There was a problem hiding this comment.
Looks great! Left some very minor suggestions on labeling. I also can't think of why the code coverage dropped... 🤔
| value: Union[dict, list, object, Tuple] | ||
| ) -> Union[dict, list, Any]: | ||
| if isinstance(value, list): # skipcq: PYL-R1705 | ||
| if isinstance(value, (list, Tuple)): # skipcq: PYL-R1705 |
Contributor
There was a problem hiding this comment.
I love that this line of code also uses a tuple 😆
Co-authored-by: Fil Maj <maj.fil@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request resolves #1200
Category (place an
xin each of the[ ])/docs-src(Documents, have you run./scripts/docs.sh?)/docs-src-v2(Documents, have you run./scripts/docs-v2.sh?)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements (place an
xin each[ ])python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.