Skip to content

Fix #1169 by Proxy-Authorization header generation#1172

Merged
seratch merged 1 commit intoslackapi:mainfrom
seratch:issue-1169-proxy-auth-socket-mode
Feb 7, 2022
Merged

Fix #1169 by Proxy-Authorization header generation#1172
seratch merged 1 commit intoslackapi:mainfrom
seratch:issue-1169-proxy-auth-socket-mode

Conversation

@seratch
Copy link
Copy Markdown
Contributor

@seratch seratch commented Feb 7, 2022

Summary

This pull request resolves #1169

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 3x socket-mode labels Feb 7, 2022
@seratch seratch added this to the 3.14.0 milestone Feb 7, 2022
@seratch seratch self-assigned this Feb 7, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 7, 2022 •
edited
Loading

Codecov Report

Merging #1172 (d984b77) into main (0a55e2a) will increase coverage by 0.04%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1172      +/-   ##
==========================================
+ Coverage   86.58%   86.63%   +0.04%     
==========================================
  Files         110      110              
  Lines       10780    10780              
==========================================
+ Hits         9334     9339       +5     
+ Misses       1446     1441       -5
Impacted Files Coverage Δ
slack_sdk/rtm/__init__.py 90.73% <ø> (ø)
slack_sdk/socket_mode/builtin/internals.py 72.44% <50.00%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd9eed5...d984b77. Read the comment docs.

@seratch seratch merged commit d5e7b70 into slackapi:main Feb 7, 2022
@seratch seratch deleted the issue-1169-proxy-auth-socket-mode branch February 7, 2022 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@seratch seratch

Labels

bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented socket-mode Version: 3x

Projects

None yet

Milestone

3.14.0

Development

Successfully merging this pull request may close these issues.

The built-in SocketMode client fails to establish WS connections via proxy server

1 participant

@seratch