Skip to content

Add accessibility_label to button block element#1167

Merged
seratch merged 1 commit intoslackapi:mainfrom
seratch:accessibility_label
Feb 1, 2022
Merged

Add accessibility_label to button block element#1167
seratch merged 1 commit intoslackapi:mainfrom
seratch:accessibility_label

Conversation

@seratch
Copy link
Copy Markdown
Contributor

@seratch seratch commented Feb 1, 2022

Summary

This pull request adds "accessibility_label" to the "button" type block element.

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added enhancement M-T: A feature request for new functionality web-client Version: 3x labels Feb 1, 2022
@seratch seratch added this to the 3.14.0 milestone Feb 1, 2022
@seratch seratch requested review from filmaj and srajiang February 1, 2022 09:11
@seratch seratch self-assigned this Feb 1, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 1, 2022

Codecov Report

Merging #1167 (dd516da) into main (555c891) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1167   +/-   ##
=======================================
  Coverage   86.61%   86.62%           
=======================================
  Files         110      110           
  Lines       10774    10778    +4     
=======================================
+ Hits         9332     9336    +4     
  Misses       1442     1442
Impacted Files Coverage Δ
slack_sdk/models/blocks/block_elements.py 92.84% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 555c891...dd516da. Read the comment docs.

filmaj
filmaj approved these changes Feb 1, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 👨‍🍳 💋
:shipit:

srajiang
srajiang approved these changes Feb 1, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@srajiang srajiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seratch
Copy link
Copy Markdown
Contributor Author

seratch commented Feb 1, 2022

Thanks for your reviews!

@seratch seratch merged commit 779cff5 into slackapi:main Feb 1, 2022
@seratch seratch deleted the accessibility_label branch February 1, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@filmaj filmaj filmaj approved these changes

@srajiang srajiang srajiang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@seratch seratch

Labels

enhancement M-T: A feature request for new functionality Version: 3x web-client

Projects

None yet

Milestone

3.14.0

Development

Successfully merging this pull request may close these issues.

3 participants

@seratch @filmaj @srajiang