Skip to content

v3.13.0b1#1155

Merged
srajiang merged 1 commit intoslackapi:feat-hermesfrom
srajiang:v3.13.0b1
Dec 15, 2021
Merged

v3.13.0b1#1155
srajiang merged 1 commit intoslackapi:feat-hermesfrom
srajiang:v3.13.0b1

Conversation

@srajiang
Copy link
Copy Markdown
Contributor

@srajiang srajiang commented Dec 15, 2021

Summary

Contains support for Subscribe in Slack + Message Metadata

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@srajiang srajiang self-assigned this Dec 15, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 15, 2021

Codecov Report

Merging #1155 (ec36f28) into feat-hermes (0606947) will decrease coverage by 0.13%.
The diff coverage is 35.71%.

Impacted file tree graph

@@               Coverage Diff               @@
##           feat-hermes    #1155      +/-   ##
===============================================
- Coverage        86.65%   86.52%   -0.14%     
===============================================
  Files              110      110              
  Lines            10760    10787      +27     
===============================================
+ Hits              9324     9333       +9     
- Misses            1436     1454      +18
Impacted Files Coverage Δ
slack_sdk/web/async_client.py 84.39% <33.33%> (-0.47%) ⬇️
slack_sdk/web/client.py 85.80% <33.33%> (-0.49%) ⬇️
slack_sdk/web/legacy_client.py 85.51% <33.33%> (-0.49%) ⬇️
slack_sdk/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b83f17b...ec36f28. Read the comment docs.

@srajiang srajiang merged commit 05b48f8 into slackapi:feat-hermes Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevengill stevengill stevengill approved these changes

@seratch seratch Awaiting requested review from seratch

Assignees

@srajiang srajiang

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@srajiang @stevengill