Fix #1143 Keep Retry-After header compatibility wit 2.x series#1148
Merged
seratch merged 1 commit intoslackapi:mainfrom Dec 10, 2021
Merged
Fix #1143 Keep Retry-After header compatibility wit 2.x series#1148seratch merged 1 commit intoslackapi:mainfrom
seratch merged 1 commit intoslackapi:mainfrom
Conversation
seratch
commented
Dec 9, 2021
| if "ratelimited" in pattern: | ||
| self.send_response(429) | ||
| self.send_header("Retry-After", 1) | ||
| self.send_header("retry-after", 1) |
Contributor
Author
There was a problem hiding this comment.
Changed the mock API server's behavior -- with this, the existing test assets detect the lack of the Retry-After header
Codecov Report
@@ Coverage Diff @@
## main #1148 +/- ##
==========================================
+ Coverage 86.62% 86.65% +0.02%
==========================================
Files 110 110
Lines 10755 10760 +5
==========================================
+ Hits 9317 9324 +7
+ Misses 1438 1436 -2
Continue to review full report at Codecov.
|
5a768d2 to
a3bae59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes #1143, which is a regression bug since v3.12.0. For code consistency, I've updated all the clients but actually only
WebClienthad this issue.Category (place an
xin each of the[ ])/docs-src(Documents, have you run./scripts/docs.sh?)/docs-src-v2(Documents, have you run./scripts/docs-v2.sh?)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements (place an
xin each[ ])python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.