Skip to content

Add focus_on_load support in Block Kit#1140

Merged
seratch merged 1 commit intoslackapi:mainfrom
seratch:focus_on_load
Nov 29, 2021
Merged

Add focus_on_load support in Block Kit#1140
seratch merged 1 commit intoslackapi:mainfrom
seratch:focus_on_load

Conversation

@seratch
Copy link
Copy Markdown
Contributor

@seratch seratch commented Nov 29, 2021

Summary

This pull requset adds the new property "focus_on_load" to the Block Kit elements that support it.

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added this to the 3.13.0 milestone Nov 29, 2021
@seratch seratch self-assigned this Nov 29, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 29, 2021

Codecov Report

Merging #1140 (566dd47) into main (2f820ae) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1140      +/-   ##
==========================================
- Coverage   86.63%   86.59%   -0.05%     
==========================================
  Files         110      110              
  Lines       10754    10755       +1     
==========================================
- Hits         9317     9313       -4     
- Misses       1437     1442       +5
Impacted Files Coverage Δ
slack_sdk/models/blocks/block_elements.py 92.77% <100.00%> (+0.25%) ⬆️
slack_sdk/socket_mode/builtin/internals.py 70.22% <0.00%> (-1.78%) ⬇️
slack_sdk/socket_mode/websocket_client/__init__.py 84.17% <0.00%> (-1.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f820ae...566dd47. Read the comment docs.

srajiang
srajiang approved these changes Nov 29, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@srajiang srajiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me!

I'm not clear on why the codecov reporting shows some loss of coverage see https://app.codecov.io/gh/slackapi/python-slack-sdk/compare/1140/changes

filmaj
filmaj approved these changes Nov 29, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@filmaj
Copy link
Copy Markdown
Contributor

filmaj commented Nov 29, 2021

@srajiang good question! It seems like something in the most recent commits on main, between when the last tag was released and the current main HEAD, contributed to at least the slack_sdk/socket_mode/websocket_client/__init__.py coverage drop - but that doesnt explain the internals drop in coverage, esp. since the changes mostly look to be documentation 😬

@seratch
Copy link
Copy Markdown
Contributor Author

seratch commented Nov 29, 2021

Thanks for the reviews. Yeah, I have observed this kind of unexpected coverage drop a few times in the past 🤷

@seratch seratch merged commit 7c62978 into slackapi:main Nov 29, 2021
@seratch seratch deleted the focus_on_load branch November 29, 2021 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevengill stevengill Awaiting requested review from stevengill

2 more reviewers

@filmaj filmaj filmaj approved these changes

@srajiang srajiang srajiang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@seratch seratch

Labels

Version: 3x web-client

Projects

None yet

Milestone

3.13.0

Development

Successfully merging this pull request may close these issues.

3 participants

@seratch @filmaj @srajiang