Skip to content

Audit Logs API: Add new details properties for channel_posting_permissions_updated action#1130

Merged
seratch merged 1 commit intoslackapi:mainfrom
seratch:add-audit-logs-response-attributes
Oct 21, 2021
Merged

Audit Logs API: Add new details properties for channel_posting_permissions_updated action#1130
seratch merged 1 commit intoslackapi:mainfrom
seratch:add-audit-logs-response-attributes

Conversation

@seratch
Copy link
Copy Markdown
Contributor

@seratch seratch commented Oct 21, 2021

Summary

This pull request adds two new properties to the Audit Logs API response data class. "who_can_post" and "can_thread" can be included in "channel_posting_permissions_updated" action response starting today. See also: slackapi/java-slack-sdk@62f93c7

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added this to the 3.12.0 milestone Oct 21, 2021
@seratch seratch self-assigned this Oct 21, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 21, 2021

Codecov Report

Merging #1130 (1fed9f6) into main (77e906a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1130      +/-   ##
==========================================
+ Coverage   87.99%   88.00%   +0.01%     
==========================================
  Files         110      110              
  Lines       10708    10719      +11     
==========================================
+ Hits         9422     9433      +11     
  Misses       1286     1286
Impacted Files Coverage Δ
slack_sdk/audit_logs/v1/logs.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77e906a...1fed9f6. Read the comment docs.

@seratch seratch merged commit 93fd69a into slackapi:main Oct 21, 2021
@seratch seratch deleted the add-audit-logs-response-attributes branch October 21, 2021 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mwbrooks mwbrooks Awaiting requested review from mwbrooks

@stevengill stevengill Awaiting requested review from stevengill

@srajiang srajiang Awaiting requested review from srajiang

1 more reviewer

@filmaj filmaj filmaj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@seratch seratch

Labels

audit-logs-client Version: 3x

Projects

None yet

Milestone

3.12.0

Development

Successfully merging this pull request may close these issues.

2 participants

@seratch @filmaj