Skip to content

Add Python 3.10 to the supported versions#1129

Merged
seratch merged 1 commit intoslackapi:mainfrom
seratch:python-3.10-support
Oct 17, 2021
Merged

Add Python 3.10 to the supported versions#1129
seratch merged 1 commit intoslackapi:mainfrom
seratch:python-3.10-support

Conversation

@seratch
Copy link
Copy Markdown
Contributor

@seratch seratch commented Oct 17, 2021

Summary

This pull request adds Python 3.10 runtime to the supported ones since the next release.

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added this to the 3.12.0 milestone Oct 17, 2021
@seratch seratch self-assigned this Oct 17, 2021
@seratch seratch force-pushed the python-3.10-support branch from 5359e1a to c13316c Compare October 17, 2021 05:20
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 17, 2021 •
edited
Loading

Codecov Report

Merging #1129 (9a631d5) into main (6ce55a3) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 9a631d5 differs from pull request most recent head 6bfee09. Consider uploading reports for the commit 6bfee09 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1129      +/-   ##
==========================================
- Coverage   88.10%   88.08%   -0.02%     
==========================================
  Files         110      110              
  Lines       10681    10681              
==========================================
- Hits         9410     9408       -2     
- Misses       1271     1273       +2
Impacted Files Coverage Δ
slack_sdk/socket_mode/websocket_client/__init__.py 84.17% <0.00%> (-1.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ce55a3...6bfee09. Read the comment docs.

@seratch seratch force-pushed the python-3.10-support branch from ce4ff6c to 6bfee09 Compare October 17, 2021 08:47
@seratch
Copy link
Copy Markdown
Contributor Author

seratch commented Oct 17, 2021

As this is safe enough, let me merge it now

@seratch seratch merged commit 114063d into slackapi:main Oct 17, 2021
@seratch seratch deleted the python-3.10-support branch October 17, 2021 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@seratch seratch

Labels

audit-logs-client enhancement M-T: A feature request for new functionality oauth rtm-client scim-client socket-mode Version: 3x web-client

Projects

None yet

Milestone

3.12.0

Development

Successfully merging this pull request may close these issues.

1 participant

@seratch