Skip to content

Fix #1055 Socket Mode: ENOTSOCK every 300 minutes on Windows#1091

Merged
seratch merged 2 commits intoslackapi:mainfrom
seratch:issue-1055-windows-socket-error
Aug 13, 2021
Merged

Fix #1055 Socket Mode: ENOTSOCK every 300 minutes on Windows#1091
seratch merged 2 commits intoslackapi:mainfrom
seratch:issue-1055-windows-socket-error

Conversation

@seratch
Copy link
Copy Markdown
Contributor

@seratch seratch commented Aug 13, 2021

Summary

This pull request fixes #1055 by adding an error handling code for a pattern specific to Windows OS.

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./docs.sh?)
  • /docs-src-v2 (Documents, have you run ./docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added this to the 3.9.0 milestone Aug 13, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 13, 2021 •
edited
Loading

Codecov Report

Merging #1091 (79ec5ff) into main (b2364d2) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1091   +/-   ##
=======================================
  Coverage   86.19%   86.19%           
=======================================
  Files         110      110           
  Lines        9928     9928           
=======================================
  Hits         8557     8557           
  Misses       1371     1371
Impacted Files Coverage Δ
slack_sdk/socket_mode/builtin/internals.py 48.43% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2364d2...79ec5ff. Read the comment docs.

seratch
seratch commented Aug 13, 2021
View reviewed changes
slack_sdk/socket_mode/builtin/internals.py
if e.errno == errno.EBADF:
# For Linux/macOS, errno.EBADF is the expected error for bad connections.
# The errno.ENOTSOCK can be sent when running on Windows OS.
if e.errno in (errno.EBADF, errno.ENOTSOCK):
Copy link
Copy Markdown
Contributor Author

@seratch seratch Aug 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed ENOTSOCK does exist for all supported Python versions (3.6+)

@seratch seratch merged commit 48602cf into slackapi:main Aug 13, 2021
@seratch seratch deleted the issue-1055-windows-socket-error branch August 13, 2021 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

socket-mode Version: 3x

Projects

None yet

Milestone

3.9.0

Development

Successfully merging this pull request may close these issues.

Socket Mode: ENOTSOCK every 300 minutes on Windows

1 participant

@seratch