Set max length for string columns in SQLAlchemy models for MySQL compatibility#1040
Merged
seratch merged 2 commits intoslackapi:mainfrom Jun 16, 2021
Merged
Conversation
|
|
Contributor
|
Hi @tattee, thank you very much for takin the time to make this pull request. Before my code review, I have two things to ask:
Even if your changes are great, we are unable to merge them without signed CLA. I would appreciate it if you could understand this. |
seratch
approved these changes
Jun 15, 2021
Codecov Report
@@ Coverage Diff @@
## main #1040 +/- ##
==========================================
- Coverage 84.33% 84.31% -0.03%
==========================================
Files 95 95
Lines 8938 8938
==========================================
- Hits 7538 7536 -2
- Misses 1400 1402 +2
Continue to review full report at Codecov.
|
4049f4c to
b805a3d
Compare
Contributor
|
Thanks for working on this. Let me merge this change. |
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I tried slackapi/bolt-python with MySQL server using SQLAlchemy, I encountered an error, 'InvalidRequestError: VARCHAR requires a length on dialect mysql'.
Therefore, I edited max length of the String in the wrappers of InstallationStore and OAuthStateStore for SQLAlchemy.
I don't know the appropriate values for the max length of Strings, so please set those values appropriately.